wip: rework the dotnet toolchain #2298
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…m dotnet sdk (still targetting net45 for now)
|
With #2512, fstar.exe is no longer available as a .NET binary, closing this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
update the F# bootstrapping VS solution to use uptodate/cross platform dotnet sdk (still targetting net45 for now)
not sure if this breaks anything and WIP open to feedback/suggestions.
CI likely to break if there is no "dotnet" sdk on it, it should probably be updated to have the most recent release version of the SDK.
Locally, it does produce fstar.exe for same .net 4.5 runtime as what was there before (although the whole nuget thing doesn't work anymore as it stands in master so couldn't check 100% out of the box).
I've not touched the jsbackend project yet, not sure what it is about but doesn't seem to be part of the solution.